Thread (58 messages) 58 messages, 11 authors, 2020-10-14

Re: [PATCH 05/14] fs: don't allow kernel reads and writes without iter ops

From: Christoph Hellwig <hch@infradead.org>
Date: 2020-10-14 08:19:41
Also in: linux-arch, linux-fsdevel, lkml

On Sat, Oct 10, 2020 at 01:55:24AM +0000, Alexander Viro wrote:
FWIW, I hadn't pushed that branch out (or merged it into #for-next yet);
for one thing, uml part (mconsole) is simply broken, for another...
IMO ##5--8 are asking for kernel_pread() and if you look at binfmt_elf.c,
you'll see elf_read() being pretty much that.  acct.c, keys and usermode
parts are asking for kernel_pwrite() as well.

I've got stuck looking through the drivers/target stuff - it would've
been another kernel_pwrite() candidate, but it smells like its use of
filp_open() is really asking for trouble, starting with symlink attacks.
Not sure - I'm not familiar with the area, but...
Can you just pull in the minimal fix so that the branch gets fixed
for this merge window?  All the cleanups can come later.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help