Re: [PATCH] powerpc/mm: Remove DEBUG_VM_PGTABLE support on ppc64

Le 01/09/2020 à 10:12, Aneesh Kumar K.V a écrit :

On 9/1/20 1:40 PM, Christophe Leroy wrote:

quoted

Le 01/09/2020 à 10:02, Aneesh Kumar K.V a écrit :

quoted

The test is broken w.r.t page table update rules and results in kernel
crash as below. Disable the support untill we get the tests updated.


Signed-off-by: Aneesh Kumar K.V <redacted>

Any Fixes: tag ?

quoted

---
  arch/powerpc/Kconfig | 1 -
  1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 65bed1fdeaad..787e829b6f25 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -116,7 +116,6 @@ config PPC

      #
      select ARCH_32BIT_OFF_T if PPC32
      select ARCH_HAS_DEBUG_VIRTUAL
-    select ARCH_HAS_DEBUG_VM_PGTABLE

You say you remove support for ppc64 but you are removing it for both 
PPC64 and PPC32. Should you replace the line by:

Does it work on PPC32 with DEBUG_VM enabled? I was expecting it will be 
broken there too.

I was wondering. I have just started a build to test that on my 8xx. 
I'll tell you before noon (Paris).

Christophe

quoted

     select ARCH_HAS_DEBUG_VM_PGTABLE if PPC32

quoted

      select ARCH_HAS_DEVMEM_IS_ALLOWED
      select ARCH_HAS_ELF_RANDOMIZE
      select ARCH_HAS_FORTIFY_SOURCE

What about 
Documentation/features/debug/debug-vm-pgtable/arch-support.txt ?

I am hoping we can enable the config once we resolve the test issues. 
may be in next merge window.

-aneesh