Re: [PATCH] rpadlpar_io:Add MODULE_DESCRIPTION entries to kernel modules
From: "Oliver O'Halloran" <oohall@gmail.com>
Date: 2020-09-29 00:55:24
Also in:
linux-pci, lkml
On Tue, Sep 29, 2020 at 6:50 AM Tyrel Datwyler [off-list ref] wrote:
On 9/23/20 11:41 PM, Oliver O'Halloran wrote:quoted
On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar [off-list ref] wrote:quoted
This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules (descriptions taken from Kconfig file) Signed-off-by: Mamatha Inamdar <redacted> --- drivers/pci/hotplug/rpadlpar_core.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c index f979b70..bac65ed 100644 --- a/drivers/pci/hotplug/rpadlpar_core.c +++ b/drivers/pci/hotplug/rpadlpar_core.c@@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) module_init(rpadlpar_io_init); module_exit(rpadlpar_io_exit); MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots");RPA as a spec was superseded by PAPR in the early 2000s. Can we rename this already?I seem to recall Michael and I discussed the naming briefly when I added the maintainer entries for the drivers and that the PAPR acronym is almost as meaningless to most as the original RPA. While, IBM no longer uses the term pseries for Power hardware marketing it is the defacto platform identifier in the Linux kernel tree for what we would call PAPR compliant. All in all I have no problem with renaming, but maybe we should consider pseries_dlpar or even simpler ibmdlpar.
I'm not too bothered by what we call it so long as it's consistent with *something* else in the tree. Using pseries rather than ibm as a prefix would probably be better since the legacy ibmphp driver is in the same directory.