Re: [PATCH -next v2] powerpc/perf: Fix symbol undeclared warning
From: Athira Rajeev <hidden>
Date: 2020-09-24 03:16:09
Also in:
lkml
On 23-Sep-2020, at 12:44 PM, Wang Wensheng [off-list ref] wrote: Build kernel with `C=2`: arch/powerpc/perf/isa207-common.c:24:18: warning: symbol 'isa207_pmu_format_attr' was not declared. Should it be static? arch/powerpc/perf/power9-pmu.c:101:5: warning: symbol 'p9_dd21_bl_ev' was not declared. Should it be static? arch/powerpc/perf/power9-pmu.c:115:5: warning: symbol 'p9_dd22_bl_ev' was not declared. Should it be static? Those symbols are used only in the files that define them so we declare them as static to fix the warnings.
Hi, Looks fine to me. Reviewed-by: Athira Rajeev <redacted> Thanks Athira
quoted hunk ↗ jump to hunk
Signed-off-by: Wang Wensheng <redacted> --- arch/powerpc/perf/isa207-common.c | 2 +- arch/powerpc/perf/power9-pmu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c index 964437adec18..85dc860b265b 100644 --- a/arch/powerpc/perf/isa207-common.c +++ b/arch/powerpc/perf/isa207-common.c@@ -21,7 +21,7 @@ PMU_FORMAT_ATTR(thresh_stop, "config:32-35");PMU_FORMAT_ATTR(thresh_start, "config:36-39"); PMU_FORMAT_ATTR(thresh_cmp, "config:40-49"); -struct attribute *isa207_pmu_format_attr[] = { +static struct attribute *isa207_pmu_format_attr[] = { &format_attr_event.attr, &format_attr_pmcxsel.attr, &format_attr_mark.attr,diff --git a/arch/powerpc/perf/power9-pmu.c b/arch/powerpc/perf/power9-pmu.c index 2a57e93a79dc..4a315fad1f99 100644 --- a/arch/powerpc/perf/power9-pmu.c +++ b/arch/powerpc/perf/power9-pmu.c@@ -98,7 +98,7 @@ extern u64 PERF_REG_EXTENDED_MASK;/* PowerISA v2.07 format attribute structure*/ extern struct attribute_group isa207_pmu_format_group; -int p9_dd21_bl_ev[] = { +static int p9_dd21_bl_ev[] = { PM_MRK_ST_DONE_L2, PM_RADIX_PWC_L1_HIT, PM_FLOP_CMPL,@@ -112,7 +112,7 @@ int p9_dd21_bl_ev[] = {PM_DISP_HELD_SYNC_HOLD, }; -int p9_dd22_bl_ev[] = { +static int p9_dd22_bl_ev[] = { PM_DTLB_MISS_16G, PM_DERAT_MISS_2M, PM_DTLB_MISS_2M, -- 2.25.0