Thread (6 messages) flat view 6 messages, 2 authors, 2020-09-02

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2020-09-02 01:34:25
Also in: linux-arm-kernel, lkml

On Tue, Sep 01, 2020 at 04:40:16PM -0500, Li Yang wrote:
Looks like the CAAM driver and dependent QBMAN driver doesn't support
COMPILE_TEST yet.  Are you trying to add the support for it?
Yes.
I think this is a valid concern that if the parent structure doesn't
meet certain alignment requirements, the alignment for the
sub-structure cannot be guaranteed.  If we just remove the __packed
attribute from the parent structure, the compiler could try to add
padding in the parent structure to fulfill the alignment requirements
of the sub structure which is not good.  I think the following changes
are a better fix for the warnings:
This works for me.  Thanks!
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help