Thread (3 messages) flat view 3 messages, 3 authors, 2020-08-07

Re: [PATCH] ASoC: fsl-asoc-card: Get "extal" clock rate by clk_get_rate

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2020-08-07 07:18:11
Also in: alsa-devel, lkml

On Thu, Aug 6, 2020 at 8:39 PM Mark Brown [off-list ref] wrote:
On Thu, Aug 06, 2020 at 03:39:45PM +0800, Shengjiu Wang wrote:
quoted
      } else if (of_node_name_eq(cpu_np, "esai")) {
+             struct clk *esai_clk = clk_get(&cpu_pdev->dev, "extal");
+
+             if (!IS_ERR(esai_clk)) {
+                     priv->cpu_priv.sysclk_freq[TX] = clk_get_rate(esai_clk);
+                     priv->cpu_priv.sysclk_freq[RX] = clk_get_rate(esai_clk);
+                     clk_put(esai_clk);
+             }
This should handle probe deferral.  Also if this clock is in use
shouldn't we be enabling it?  It looks like it's intended to be a
crystal so it's probably forced on all the time but sometimes there's
power control for crystals, or perhaps someone might do something
unusual with the hardware.
Ok, will add handler for probe deferral.

This clock is not a crystal, "extal" clock is for cpu dai, it is from
soc internal PLL. which is enabled by cpu dai, here is just to
get the clock rate.

best regards
wang shengjiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help