On Tue, Aug 18, 2020 at 09:55:39PM +0200, Christoph Hellwig wrote:

On Tue, Aug 18, 2020 at 12:44:49PM -0700, Kees Cook wrote:

quoted

On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote:

quoted

For 64-bit the only hing missing was a strategic _AC, and for 32-bit we

typo: thing

quoted

need to use __PAGE_OFFSET instead of PAGE_OFFSET in the TASK_SIZE
definition to escape the explicit unsigned long cast.  This just works
because __PAGE_OFFSET is defined using _AC itself and thus never needs
the cast anyway.

Shouldn't this be folded into the prior patch so there's no bisection
problem?

I didn't see a problem bisecting, do you have something particular in
mind?

Oh, I misunderstood this patch to be a fix for compilation. Is this just
a correctness fix?

-- 
Kees Cook