Re: [PATCH 2/2] powerpc/numa: Remove a redundant variable
From: Nathan Lynch <hidden>
Date: 2020-07-22 03:31:36
Srikar Dronamraju [off-list ref] writes:
In of_drconf_to_nid_single() default_nid always refers to NUMA_NO_NODE. Hence replace it with NUMA_NO_NODE. No functional changes.
...
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index a2c5fe0d0cad..b066d89c2975 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c@@ -432,16 +432,15 @@ static int of_get_assoc_arrays(struct assoc_arrays *aa) static int of_drconf_to_nid_single(struct drmem_lmb *lmb) { struct assoc_arrays aa = { .arrays = NULL }; - int default_nid = NUMA_NO_NODE; - int nid = default_nid; + int nid = NUMA_NO_NODE; int rc, index; if ((min_common_depth < 0) || !numa_enabled) - return default_nid; + return NUMA_NO_NODE; rc = of_get_assoc_arrays(&aa); if (rc) - return default_nid; + return NUMA_NO_NODE; if (min_common_depth <= aa.array_sz && !(lmb->flags & DRCONF_MEM_AI_INVALID) && lmb->aa_index < aa.n_arrays) {@@ -449,7 +448,7 @@ static int of_drconf_to_nid_single(struct drmem_lmb *lmb) nid = of_read_number(&aa.arrays[index], 1); if (nid == 0xffff || nid >= num_possible_nodes()) - nid = default_nid; + nid = NUMA_NO_NODE; if (nid > 0) { index = lmb->aa_index * aa.array_sz;
Doesn't seem like an improvement to me, sorry. Admittedly it's a small point, but a local variable named "default_nid" communicates that it's a default or fallback value. That information is lost with this change.