Thread (42 messages) 42 messages, 5 authors, 2020-07-21

Re: [PATCH 04/11] powerpc/smp: Enable small core scheduling sooner

flat view

From: Jordan Niethe <hidden>
Date: 2020-07-20 07:53:51

On Tue, Jul 14, 2020 at 2:44 PM Srikar Dronamraju
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Enable small core scheduling as soon as we detect that we are in a
system that supports thread group. Doing so would avoid a redundant
check.

Cc: linuxppc-dev <redacted>
Cc: Michael Ellerman <redacted>
Cc: Nick Piggin <redacted>
Cc: Oliver OHalloran <redacted>
Cc: Nathan Lynch <redacted>
Cc: Michael Neuling <redacted>
Cc: Anton Blanchard <redacted>
Cc: Gautham R Shenoy <redacted>
Cc: Vaidyanathan Srinivasan <redacted>
Signed-off-by: Srikar Dronamraju <redacted>
---
 arch/powerpc/kernel/smp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 24529f6134aa..7d430fc536cc 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -892,6 +892,12 @@ static int init_big_cores(void)
        }

        has_big_cores = true;
+
+#ifdef CONFIG_SCHED_SMT
+       pr_info("Big cores detected. Using small core scheduling\n");
Why change the wording from "Big cores detected but using small core
scheduling\n"?
quoted hunk ↗ jump to hunk
+       powerpc_topology[0].mask = smallcore_smt_mask;
+#endif
+
        return 0;
 }
@@ -1383,12 +1389,6 @@ void __init smp_cpus_done(unsigned int max_cpus)

        dump_numa_cpu_topology();

-#ifdef CONFIG_SCHED_SMT
-       if (has_big_cores) {
-               pr_info("Big cores detected but using small core scheduling\n");
-               powerpc_topology[0].mask = smallcore_smt_mask;
-       }
-#endif
        set_sched_topology(powerpc_topology);
 }

--
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help