Re: [RFC PATCH 5/7] lazy tlb: introduce lazy mm refcount helper functions
From: Peter Zijlstra <peterz@infradead.org>
Date: 2020-07-10 09:48:15
Also in:
linux-arch, linux-mm, lkml
From: Peter Zijlstra <peterz@infradead.org>
Date: 2020-07-10 09:48:15
Also in:
linux-arch, linux-mm, lkml
On Fri, Jul 10, 2020 at 11:56:44AM +1000, Nicholas Piggin wrote:
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 73199470c265..ad95812d2a3f 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c@@ -1253,7 +1253,7 @@ void start_secondary(void *unused) unsigned int cpu = smp_processor_id(); struct cpumask *(*sibling_mask)(int) = cpu_sibling_mask; - mmgrab(&init_mm); + mmgrab(&init_mm); /* XXX: where is the mmput for this? */ current->active_mm = &init_mm; smp_store_cpu_info(cpu);
Right; so IIRC it should be this one:
diff --git a/kernel/cpu.c b/kernel/cpu.c index 134688d79589..ff9fcbc4e76b 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c@@ -578,7 +578,7 @@ static int finish_cpu(unsigned int cpu) */ if (mm != &init_mm) idle->active_mm = &init_mm; - mmdrop(mm); + mmdrop_lazy_tlb(mm); return 0; }