[PATCH 30/30] misc: cxl: flash: Remove unused pointer
flat view
DORMANTno replies
SUPERSEDED
From: Lee Jones <hidden>
Date: 2020-06-30 13:52:04
Also in:
linux-arm-kernel, lkml
Subsystem:
char and misc drivers, the rest · Maintainers:
Arnd Bergmann, Greg Kroah-Hartman, Linus Torvalds
Status: Superseded by v2 (posted 2020-07-01). [go to v2]
Revision v1 (2 revisions archived).
Revisions (2)
- v1 current
- v2 [diff against previous]
The DRC index pointer us updated on an OPCODE_ADD, but never
actually read. Remove the used pointer and shift up OPCODE_ADD
to group with OPCODE_DELETE which also provides a noop.
Fixes the following W=1 kernel build warning:
drivers/misc/cxl/flash.c: In function ‘update_devicetree’:
drivers/misc/cxl/flash.c:178:16: warning: variable ‘drc_index’ set but not used [-Wunused-but-set-variable]
178 | __be32 *data, drc_index, phandle;
| ^~~~~~~~~
Cc: Frederic Barrat <redacted>
Cc: Andrew Donnellan <redacted>
Cc: <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/misc/cxl/flash.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index cb9cca35a2263..24e3dfcc91a74 100644
--- a/drivers/misc/cxl/flash.c
+++ b/drivers/misc/cxl/flash.c@@ -175,7 +175,7 @@ static int update_devicetree(struct cxl *adapter, s32 scope) struct update_nodes_workarea *unwa; u32 action, node_count; int token, rc, i; - __be32 *data, drc_index, phandle; + __be32 *data, phandle; char *buf; token = rtas_token("ibm,update-nodes");
@@ -206,15 +206,12 @@ static int update_devicetree(struct cxl *adapter, s32 scope) switch (action) { case OPCODE_DELETE: + case OPCODE_ADD: /* nothing to do */ break; case OPCODE_UPDATE: update_node(phandle, scope); break; - case OPCODE_ADD: - /* nothing to do, just move pointer */ - drc_index = *data++; - break; } } }
--
2.25.1