Re: [PATCH v4 6/8] arm: Break cyclic percpu include
From: Will Deacon <will@kernel.org>
Date: 2020-06-25 07:31:53
Also in:
linux-s390, lkml, sparclinux
From: Will Deacon <will@kernel.org>
Date: 2020-06-25 07:31:53
Also in:
linux-s390, lkml, sparclinux
On Wed, Jun 24, 2020 at 07:53:20PM +0200, Peter Zijlstra wrote:
On Tue, Jun 23, 2020 at 10:02:57AM +0100, Will Deacon wrote:quoted
On Tue, Jun 23, 2020 at 10:36:51AM +0200, Peter Zijlstra wrote:quoted
In order to use <asm/percpu.h> in irqflags.h, we need to make sure asm/percpu.h does not itself depend on irqflags.h. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> --- arch/arm/include/asm/percpu.h | 2 ++ 1 file changed, 2 insertions(+)--- a/arch/arm/include/asm/percpu.h +++ b/arch/arm/include/asm/percpu.h@@ -10,6 +10,8 @@ * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7 */ #if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6) +register unsigned long current_stack_pointer asm ("sp");If you define this unconditionally, then we can probably get rid of the copy in asm/thread_info.h, rather than duplicate the same #define.The below delta seems to build arm-allnoconfig, arm-defconfig and arm-allmodconfig. Although please don't ask me how asm/thread_info.h includes asm/percpu.h Does that work for you?
Yes, thanks! I can't believe you removed the helpful comment.
-/* - * how to get the current stack pointer in C - */
Will