Re: [PATCH] mm: Move p?d_alloc_track to separate header file

On Wed, Jun 17, 2020 at 06:12:26PM -0700, Andrew Morton wrote:

On Tue,  9 Jun 2020 14:05:33 +0200 Joerg Roedel [off-list ref] wrote:

quoted

From: Joerg Roedel <redacted>

The functions are only used in two source files, so there is no need
for them to be in the global <linux/mm.h> header. Move them to the new
<linux/pgalloc-track.h> header and include it only where needed.

...

new file mode 100644
index 000000000000..1dcc865029a2

--- /dev/null
+++ b/include/linux/pgalloc-track.h

@@ -0,0 +1,51 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_PGALLLC_TRACK_H
+#define _LINUX_PGALLLC_TRACK_H

hm, no #includes.  I guess this is OK, given the limited use.

But it does make one wonder whether ioremap.c should be moved from lib/
to mm/ and this file should be moved from include/linux/ to mm/.

It makes sense, but I am anyway planning consolidation of pgalloc.h, so
most probably pgalloc-track will not survive until 5.9-rc1 :)

If you think that it worth moving ioremap.c to mm/ regardless of chrun,
I can send a patch for that.

Oh well.

-- 
Sincerely yours,
Mike.