Re: [PATCH 2/2] cpufreq: Specify default governor on command line
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2020-06-16 09:54:45
Also in:
linux-pm, lkml
On 16-06-20, 10:48, Quentin Perret wrote:
quoted hunk ↗ jump to hunk
---8<---diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 0f05caedc320..a9219404e07f 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c@@ -2340,6 +2340,11 @@ int cpufreq_register_governor(struct cpufreq_governor *governor) list_add(&governor->governor_list, &cpufreq_governor_list); } + if (!strncasecmp(cpufreq_param_governor, governor->name, CPUFREQ_NAME_LEN)) + default_governor = governor; + else if (!default_governor && cpufreq_default_governor() == governor) + default_governor = cpufreq_default_governor();
Instead of the else part here, maybe just do this from cpufreq_core_init() only once, and so we will always have default_governor set.
quoted hunk ↗ jump to hunk
+ mutex_unlock(&cpufreq_governor_mutex); return err; }@@ -2368,6 +2373,8 @@ void cpufreq_unregister_governor(struct cpufreq_governor *governor) mutex_lock(&cpufreq_governor_mutex); list_del(&governor->governor_list); + if (governor == default_governor) + default_governor = cpufreq_default_governor(); mutex_unlock(&cpufreq_governor_mutex); } EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); --->8---should do the trick. That removes the unnecessary reference count, and feels like a good place to hook things -- that is how cpuidle does it too IIRC. I'll double check the locking/synchronization, but that shouldn't be too bad (famous last words). Cheers, Quentin
-- viresh