Thread (3 messages) flat view 3 messages, 3 authors, 2020-06-16

Re: [PATCH v3] ASoC: fsl_ssi: Fix bclk calculation for mono channel

From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2020-06-16 05:23:31
Also in: alsa-devel, lkml

On Tue, Jun 16, 2020 at 10:53:48AM +0800, Shengjiu Wang wrote:
For mono channel, SSI will switch to Normal mode.

In Normal mode and Network mode, the Word Length Control bits
control the word length divider in clock generator, which is
different with I2S Master mode (the word length is fixed to
32bit), it should be the value of params_width(hw_params).

The condition "slots == 2" is not good for I2S Master mode,
because for Network mode and Normal mode, the slots can also
be 2. Then we need to use (ssi->i2s_net & SSI_SCR_I2S_MODE_MASK)
to check if it is I2S Master mode.

So we refine the formula for mono channel, otherwise there
will be sound issue for S24_LE.

Fixes: b0a7043d5c2c ("ASoC: fsl_ssi: Caculate bit clock rate using slot number and width")
Signed-off-by: Shengjiu Wang <redacted>
Reviewed-by: Nicolin Chen <nicoleotsuka@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help