Re: [PATCH? v2] powerpc: Hard wire PT_SOFTE value to 1 in gpr_get() too

From
Oleg Nesterov <oleg@redhat.com>
Date
2020-06-11 10:58:47
Also in
lkml
Reply to
Madhavan Srinivasan, 2020-06-11
On 06/11, Madhavan Srinivasan wrote:

On 6/10/20 8:37 PM, Oleg Nesterov wrote:
quoted
Hi,

looks like this patch was forgotten.
yep, I missed this. But mpe did have comments for the patch.

https://lkml.org/lkml/2019/9/19/107
Yes, and I thought that I have replied... apparently not, sorry!

So let me repeat, I am fine either way, I do not understand this
ppc-specific code and I can't really test this change.

Let me quote that email from Michael:

	> We could do it like below. I'm 50/50 though on whether it's worth it, or
	> if we should just go with the big ifdef like in your patch.
	
up to you ;)

Hmm. And yes,
quoted
quoted
This is not consistent and this breaks
http://sourceware.org/systemtap/wiki/utrace/tests/user-regs-peekpoke
this is 404.

Jan, could correct the link above?

Oleg.
Thread (8 messages) 8 messages, 5 authors, last reply 2020-06-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help