Re: [PATCH] pwm: Add missing "CONFIG_" prefix
From: Kees Cook <hidden>
Date: 2020-06-03 23:38:36
Also in:
linux-pwm, lkml
On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote:
more odd uses (mostly in comments) $ git grep -P -oh '\bIS_ENABLED\s*\(\s*\w+\s*\)'| \ sed -r 's/\s+//g'| \ grep -v '(CONFIG_' | \ sort | uniq -c | sort -rn
I think a missed a bunch because my grep was messy. :) This is much easier to scan.
7 IS_ENABLED(DEBUG)
4 IS_ENABLED(cfg)
2 IS_ENABLED(opt_name)
2 IS_ENABLED(DEBUG_PRINT_TRIE_GRAPHVIZ)
2 IS_ENABLED(config)
2 IS_ENABLED(cond)
2 IS_ENABLED(__BIG_ENDIAN)
1 IS_ENABLED(x)
1 IS_ENABLED(PWM_DEBUG)
1 IS_ENABLED(option)
1 IS_ENABLED(DEBUG_RANDOM_TRIE)
1 IS_ENABLED(DEBUG_CHACHA20POLY1305_SLOW_CHUNK_TEST)These seem to be "as expected".
4 IS_ENABLED(DRM_I915_SELFTEST)
1 IS_ENABLED(STRICT_KERNEL_RWX)
1 IS_ENABLED(ETHTOOL_NETLINK)But these are not.
quoted hunk ↗ jump to hunk
STRICT_KERNEL_RWX is misused here in ppc --- Fix pr_warn without newline too. arch/powerpc/mm/book3s64/hash_utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c index 51e3c15f7aff..dd60c5f2b991 100644 --- a/arch/powerpc/mm/book3s64/hash_utils.c +++ b/arch/powerpc/mm/book3s64/hash_utils.c@@ -660,11 +660,10 @@ static void __init htab_init_page_sizes(void) * Pick a size for the linear mapping. Currently, we only * support 16M, 1M and 4K which is the default */ - if (IS_ENABLED(STRICT_KERNEL_RWX) && + if (IS_ENABLED(CONFIG_STRICT_KERNEL_RWX) && (unsigned long)_stext % 0x1000000) { if (mmu_psize_defs[MMU_PAGE_16M].shift) - pr_warn("Kernel not 16M aligned, " - "disabling 16M linear map alignment"); + pr_warn("Kernel not 16M aligned, disabling 16M linear map alignment\n"); aligned = false; }
Reviewed-by: Kees Cook <redacted> -- Kees Cook