Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

"wanghai (M)" [off-list ref] writes:

在 2020/6/3 1:20, Markus Elfring 写道:

quoted

quoted

Fix it by adding a call to kobject_put() in the error path of
kobject_init_and_add().

Thanks for another completion of the exception handling.

Would an other patch subject be a bit nicer?

Thanks for the guidance, I will perfect this description and send a v2

quoted

…

quoted

+++ b/drivers/misc/cxl/sysfs.c

@@ -624,7 +624,7 @@ static struct afu_config_record *cxl_sysfs_afu_new_cr(struct cxl_afu *afu, int c
  	rc = kobject_init_and_add(&cr->kobj, &afu_config_record_type,
  				  &afu->dev.kobj, "cr%i", cr->cr);
  	if (rc)
-		goto err;
+		goto err1;

…

Can an other label be more reasonable here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f359287765c04711ff54fbd11645271d8e5ff763#n465

I just used the original author's label, should I replace all his labels 
like'err','err1' with reasonable one.

No.

cheers