Re: [PATCH v7 12/28] powerpc: Use a function for reading instructions
From: Alistair Popple <hidden>
Date: 2020-05-04 08:28:22
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/kernel/uprobes.c b/arch/powerpc/kernel/uprobes.c index 31c870287f2b..6893d40a48c5 100644 --- a/arch/powerpc/kernel/uprobes.c +++ b/arch/powerpc/kernel/uprobes.c@@ -174,7 +174,7 @@ bool arch_uprobe_skip_sstep(struct arch_uprobe *auprobe,struct pt_regs *regs) * emulate_step() returns 1 if the insn was successfully emulated. * For all other cases, we need to single-step in hardware. */ - ret = emulate_step(regs, auprobe->insn); + ret = emulate_step(regs, ppc_inst_read(&auprobe->insn));
I'm not a uprobe expert so I don't follow why we need this read here but the rest of the patch looked ok in that it shouldn't change behaviour (and in practice neither should the above) so: Reviewed-by: Alistair Popple <redacted>
if (ret > 0) return true;