Thread (18 messages) 18 messages, 3 authors, 2020-05-13

Re: [PATCH 03/12] mm: reorder includes after introduction of linux/pgtable.h

From: Mike Rapoport <rppt@kernel.org>
Date: 2020-05-13 05:21:53
Also in: linux-alpha, linux-arch, linux-mm, linux-riscv, linux-um

On Tue, May 12, 2020 at 12:20:13PM -0700, Matthew Wilcox wrote:
On Tue, May 12, 2020 at 09:44:13PM +0300, Mike Rapoport wrote:
quoted
diff --git a/arch/alpha/kernel/proto.h b/arch/alpha/kernel/proto.h
index a093cd45ec79..701a05090141 100644
--- a/arch/alpha/kernel/proto.h
+++ b/arch/alpha/kernel/proto.h
@@ -2,8 +2,6 @@
 #include <linux/interrupt.h>
 #include <linux/io.h>
 
-#include <linux/pgtable.h>
-
 /* Prototypes of functions used across modules here in this directory.  */
 
 #define vucp	volatile unsigned char  *
Looks like your script has a bug if linux/pgtable.h is the last include
in the file?
Script indeed cannot handle all the corner case, but this is not one of
them.
I've started initially to look into removing asm/pgtable.h if it was not
needed, but I've run out of patience very soon. This file is what
sneaked in from that attempt.

-- 
Sincerely yours,
Mike.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help