Thread (1 message) 1 message, 1 author, 2020-05-29

Re: [PATCH 01/13] sysctl: add new register_sysctl_subdir() helper

flat view

From: Eric W. Biederman <hidden>
Date: 2020-05-29 12:44:34
Also in: intel-gfx, lkml, ocfs2-devel

Luis Chamberlain [off-list ref] writes:
Often enough all we need to do is create a subdirectory so that
we can stuff sysctls underneath it. However, *if* that directory
was already created early on the boot sequence we really have no
need to use the full boiler plate code for it, we can just use
local variables to help us guide sysctl to place the new leaf files.

So use a helper to do precisely this.
Reset restart.  This is patch is total nonsense.

- You are using register_sysctl_table which as I believe I have
  mentioned is a deprecated compatibility wrapper.  The point of
  spring house cleaning is to get off of the deprecated functions
  isn't it?

- You are using the old nasty form for creating directories instead
  of just passing in a path.

- None of this is even remotely necessary.  The directories
  are created automatically if you just register their entries.

Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help