Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir()
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2020-05-29 12:09:17
Also in:
dri-devel, intel-gfx, lkml, ocfs2-devel
On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote:
On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote:quoted
From: Xiaoming Ni <redacted> Move the firmware config sysctl table to fallback_table.c and use the new register_sysctl_subdir() helper. This removes the clutter from kernel/sysctl.c. Signed-off-by: Xiaoming Ni <redacted> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/base/firmware_loader/fallback.c | 4 ++++ drivers/base/firmware_loader/fallback.h | 11 ++++++++++ drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- include/linux/sysctl.h | 1 - kernel/sysctl.c | 7 ------ 5 files changed, 35 insertions(+), 10 deletions(-)So it now takes more lines than the old stuff? :(
Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis