Thread (4 messages) flat view 4 messages, 2 authors, 2020-05-22

Re: [v2 1/2] dts: ppc: t4240rdb: remove interrupts property

From: Li Yang <hidden>
Date: 2020-05-22 19:20:54
Also in: linux-devicetree, linux-rtc, lkml

On Wed, May 20, 2020 at 4:21 AM Biwen Li [off-list ref] wrote:
From: Biwen Li <redacted>

This removes interrupts property to drop warning as follows:
    - $ hwclock.util-linux
      hwclock.util-linux: select() to /dev/rtc0
      to wait for clock tick timed out

My case:
    - RTC ds1374's INT pin is connected to VCC on T4240RDB,
      then the RTC cannot inform cpu about the alarm interrupt
The commit message need a little bit improvement.  Something like:

Since the interrupt pin for RTC DS1374 is not connected to the CPU on
T4240RDB, remove
the interrupt property from the device tree.

This also fix the following warning for hwclock.util-linux:
  $ hwclock.util-linux
   hwclock.util-linux: select() to /dev/rtc0
   to wait for clock tick timed out
quoted hunk ↗ jump to hunk
Signed-off-by: Biwen Li <redacted>
---
 arch/powerpc/boot/dts/fsl/t4240rdb.dts | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
index a56a705d41f7..145896f2eef6 100644
--- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
@@ -144,7 +144,6 @@
                        rtc@68 {
                                compatible = "dallas,ds1374";
                                reg = <0x68>;
-                               interrupts = <0x1 0x1 0 0>;
                        };
                };

--
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help