Hi Michael,

On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote:

[ + Dmitry & linux-input ]

Nathan Chancellor [off-list ref] writes:

quoted

This causes a build error with CONFIG_WALNUT because kb_cs and kb_data
were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and
include/asm-ppc").

ld.lld: error: undefined symbol: kb_cs

quoted

referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a
referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a
referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a

ld.lld: error: undefined symbol: kb_data

quoted

referenced by i8042.c:309 (drivers/input/serio/i8042.c:309)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a
referenced by i8042-ppcio.h:33 (drivers/input/serio/i8042-ppcio.h:33)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a
referenced by i8042.c:319 (drivers/input/serio/i8042.c:319)
input/serio/i8042.o:(__i8042_command) in archive drivers/built-in.a
referenced 15 more times

Presumably since nobody has noticed this for the last 12 years, there is
not anyone actually trying to use this driver so we can just remove this
special walnut code and use the generic header so it builds for all
configurations.

Fixes: 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc")
Reported-by: kbuild test robot <redacted>
Signed-off-by: Nathan Chancellor <redacted>
---
 drivers/input/serio/i8042-ppcio.h | 57 -------------------------------
 drivers/input/serio/i8042.h       |  2 --
 2 files changed, 59 deletions(-)
 delete mode 100644 drivers/input/serio/i8042-ppcio.h

This LGTM.

Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)

I assumed drivers/input/serio would be pretty quiet, but there's
actually some commits to it in linux-next. So perhaps this should go via
the input tree.

Dmitry do you want to take this, or should I take it via powerpc?

Original patch is here:
  https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancellor@gmail.com (local)

I'm fine with you taking it through powerpc.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Also, while I have your attention ;), could you please ack or take
https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ (local) as I
believe this is the last user or input_polled_dev API and I would like
to drop it from the tree.

Thanks!

-- 
Dmitry