Re: remove a few uses of ->queuedata

From
Christoph Hellwig <hch@lst.de>
Date
2020-05-12 08:08:26
Also in
linux-bcache, linux-block, linux-m68k, linux-raid, lkml, nvdimm
Reply to
Dan Williams, 2020-05-09
On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote:
quoted
which are all used in the I/O submission path (generic_make_request /
generic_make_request_checks).  This is mostly a prep cleanup patch to
also remove the pointless queue argument from ->make_request - then
->queue is an extra dereference and extra churn.
Ah ok. If the changelogs had been filled in with something like "In
preparation for removing @q from make_request_fn, stop using
->queuedata", I probably wouldn't have looked twice.

For the nvdimm/ driver updates you can add:

    Reviewed-by: Dan Williams [off-list ref]

...or just let me know if you want me to pick those up through the nvdimm tree.
I'd love you to pick them up through the nvdimm tree.  Do you want
to fix up the commit message yourself?
Thread (28 messages) 28 messages, 5 authors, 2020-05-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help