Re: [PATCH V1 09/10] arch/kmap: Define kmap_atomic_prot() for all arch's
From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2020-05-01 02:37:43
Also in:
dri-devel, linux-arm-kernel, linux-mips, lkml, sparclinux
On Thu, Apr 30, 2020 at 01:38:44PM -0700, ira.weiny@intel.com wrote:
-static inline void *kmap_atomic(struct page *page)
+static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
{
preempt_disable();
pagefault_disable();
if (!PageHighMem(page))
return page_address(page);
- return kmap_atomic_high(page);
+ return kmap_atomic_high_prot(page, prot);
}
+#define kmap_atomic(page) kmap_atomic_prot(page, kmap_prot)OK, so it *was* just a bisect hazard - you return to original semantics wrt preempt_disable()...