Re: [PATCH 6/8] simplefs: add file creation functions

On 20/04/20 16:28, Greg Kroah-Hartman wrote:

quoted

I assume you meant a new file. These new functions are used only by a few
filesystems, and I didn't want to include them in vmlinux unconditionally,
so I introduced simplefs.c and CONFIG_SIMPLEFS instead of extending libfs.c.
In this way only fs that need this code like debugfs and tracefs will load
it.

Nothing "loads it", why not just make these libfs functions instead?  As
the difference between the two is not obvious at all, please don't make
things confusing.

I think Emanuele meant "will link it" not "will load it".

Emanuele, you can just move everything to libfs.c and get rid of
CONFIG_SIMPLEFS too.  "Do less" is not an offer you want to turn down!

Thanks,

Paolo