Re: [PATCH] ASoC: fsl_esai: Remove expensive print in irq handler

Hi

On Tue, Apr 21, 2020 at 5:53 PM Mark Brown [off-list ref] wrote:

On Tue, Apr 21, 2020 at 04:41:23PM +0800, Shengjiu Wang wrote:

quoted

Use dev_dbg instead of dev_err in irq handler, the dev_err
is expensive, we don't need the message to be printed everytime,
which is almost a debug option.

quoted

      if (esr & ESAI_ESR_RFF_MASK)
-             dev_warn(&pdev->dev, "isr: Receiving overrun\n");
+             dev_dbg(&pdev->dev, "isr: Receiving overrun\n");

      if (esr & ESAI_ESR_TFE_MASK)
-             dev_warn(&pdev->dev, "isr: Transmission underrun\n");
+             dev_dbg(&pdev->dev, "isr: Transmission underrun\n");

These are error messages which would suggest a problem that'd lead to
data corruption, it seems bad not to try to flag that to the user -
surely we've got bigger problems than performance if this happens?
Perhaps convert to a ratelimited print if the issue is that when errors
happen they happen a lot?

Thanks for review, I will rethink about this.

best regards
wang shengjiu