Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit()

[PATCH 0/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Waiman Long <longman@redhat.com> · 2020-04-13
[PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Waiman Long <longman@redhat.com> · 2020-04-13
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · David Rientjes <rientjes@google.com> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · "Jason A. Donenfeld" <Jason@zx2c4.com> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Michal Hocko <mhocko@kernel.org> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · David Sterba <hidden> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Waiman Long <longman@redhat.com> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · David Howells <dhowells@redhat.com> · 2020-04-14
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Johannes Weiner <hannes@cmpxchg.org> · 2020-04-15
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Dan Carpenter <hidden> · 2020-06-15
Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() · Waiman Long <longman@redhat.com> · 2020-06-15
[PATCH 2/2] crypto: Remove unnecessary memzero_explicit() · Waiman Long <longman@redhat.com> · 2020-04-13
Re: [PATCH 2/2] crypto: Remove unnecessary memzero_explicit() · Joe Perches <joe@perches.com> · 2020-04-13
Re: [PATCH 2/2] crypto: Remove unnecessary memzero_explicit() · Waiman Long <longman@redhat.com> · 2020-04-13
[PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Waiman Long <longman@redhat.com> · 2020-04-13
Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Christophe Leroy <hidden> · 2020-04-14
Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Waiman Long <longman@redhat.com> · 2020-04-14
Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Michal Suchánek <hidden> · 2020-04-14
Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Waiman Long <longman@redhat.com> · 2020-04-14
Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit() · Joe Perches <joe@perches.com> · 2020-04-14

From: Joe Perches <joe@perches.com>
Date: 2020-04-14 19:57:33
Also in: cocci, intel-wired-lan, keyrings, linux-amlogic, linux-arm-kernel, linux-bluetooth, linux-btrfs, linux-cifs, linux-crypto, linux-fscrypt, linux-integrity, linux-mediatek, linux-mm, linux-nfs, linux-pm, linux-s390, linux-scsi, linux-sctp, linux-security-module, linux-wireless, lkml, netdev, target-devel, virtualization

On Tue, 2020-04-14 at 15:37 -0400, Waiman Long wrote:

OK, I can change it to clear the key length when the allocation failed
which isn't likely.


Perhaps:

	kfree_sensitive(op->key);
	op->key = NULL;
	op->keylen = 0;

but I don't know that it impacts any possible state.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help