Thread (10 messages) 10 messages, 5 authors, 2020-05-22

Re: usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

From: Markus Elfring <hidden>
Date: 2020-04-10 08:30:31
Also in: kernel-janitors, linux-usb, lkml

Hardware experiments show that the negative return value is not just "-EPROBE_DEFER".
How much will this specific error code influence our understanding
of the discussed software situation?

quoted
quoted
+        ret = udc_controller->irq ? : -ENODEV;
Will it be clearer to specify values for all cases in such a conditional operator
(instead of leaving one case empty)?
I don't know what you mean of "instead of leaving one case empty".
I suggest to reconsider also the proposed specification “… ? : …”.

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help