Thread (8 messages) 8 messages, 5 authors, 2020-03-17

Re: [PATCH] powerpc/vdso: remove deprecated VDS64_HAS_DESCRIPTORS references

From: Michael Ellerman <hidden>
Date: 2020-03-17 13:37:13

On Mon, 2020-02-24 at 21:18:48 UTC, Joe Lawrence wrote:
The original 2005 patch that introduced the powerpc vdso, pre-git
("ppc64: Implement a vDSO and use it for signal trampoline") notes that:

  ... symbols exposed by the vDSO aren't "normal" function symbols, apps
  can't be expected to link against them directly, the vDSO's are both
  seen as if they were linked at 0 and the symbols just contain offsets
  to the various functions.  This is done on purpose to avoid a
  relocation step (ppc64 functions normally have descriptors with abs
  addresses in them).  When glibc uses those functions, it's expected to
  use it's own trampolines that know how to reach them.

Despite that explanation, there remains dead #ifdef
VDS64_HAS_DESCRIPTORS code-blocks that provide alternate function
definitions that setup function descriptors.

Since VDS64_HAS_DESCRIPTORS has been unused for all these years, we
might as well finally remove it from the codebase.

Link: https://lists.ozlabs.org/pipermail/linuxppc-dev/2020-February/204430.=
html
Link: https://lore.kernel.org/lkml/1108002773.7733.196.camel@gaston/ (local)
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ffd3eaf178b0f616a071e510e289d937330b0b35

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help