Thread (3 messages) flat view 3 messages, 3 authors, 2020-03-17

Re: [PATCH] powerpc: fix emulate_step std test

From: Ravi Bangoria <hidden>
Date: 2020-02-27 07:40:53


On 2/26/20 11:23 AM, Nicholas Piggin wrote:
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Ravi Bangoria <redacted>
quoted hunk ↗ jump to hunk
---
  arch/powerpc/lib/test_emulate_step.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c
index 42347067739c..00d70253cb5b 100644
--- a/arch/powerpc/lib/test_emulate_step.c
+++ b/arch/powerpc/lib/test_emulate_step.c
@@ -160,7 +160,7 @@ static void __init test_std(void)
  
  	/* std r5, 0(r3) */
  	stepped = emulate_step(&regs, TEST_STD(5, 3, 0));
-	if (stepped == 1 || regs.gpr[5] == a)
+	if (stepped == 1 && regs.gpr[5] == a)
  		show_result("std", "PASS");
  	else
  		show_result("std", "FAIL");
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help