Thread (12 messages) 12 messages, 5 authors, 2020-02-11

Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers

From: Christophe Leroy <hidden>
Date: 2020-02-11 05:33:55
Also in: linux-alpha, linux-mm, linux-riscv, oe-kbuild-all


Le 11/02/2020 à 03:25, Anshuman Khandual a écrit :

On 02/10/2020 04:36 PM, Russell King - ARM Linux admin wrote:
quoted
There are good reasons for the way ARM does stuff.  The generic crap was
written without regard for the circumstances that ARM has, and thus is
entirely unsuitable for 32-bit ARM.
Since we dont have an agreement here, lets just settle with disabling the
test for now on platforms where the build fails. CONFIG_EXPERT is enabling
this test for better adaptability and coverage, hence how about re framing
the config like this ? This at the least conveys the fact that EXPERT only
works when platform is neither IA64 or ARM.
Agreed
config DEBUG_VM_PGTABLE
	bool "Debug arch page table for semantics compliance"
	depends on MMU
	depends on ARCH_HAS_DEBUG_VM_PGTABLE || (EXPERT &&  !(IA64 || ARM))
I think it's maybe better to have a dedicated depends line:

depends on !IA64 && !ARM
depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT

The day arm and/or ia64 is ready for building the test, we can remove 
that depends.
	default n if !ARCH_HAS_DEBUG_VM_PGTABLE
	default y if DEBUG_VM
Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help