Re: [PATCH v3 1/4] ASoC: fsl_asrc: Change asrc_width to asrc_format
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2020-02-27 03:41:26
Also in:
alsa-devel, linux-devicetree, lkml
On Thu, Feb 27, 2020 at 10:41:55AM +0800, Shengjiu Wang wrote:
quoted hunk ↗ jump to hunk
asrc_format is more inteligent variable, which is align with the alsa definition snd_pcm_format_t. Signed-off-by: Shengjiu Wang <redacted> --- sound/soc/fsl/fsl_asrc.c | 23 +++++++++++------------ sound/soc/fsl/fsl_asrc.h | 4 ++-- sound/soc/fsl/fsl_asrc_dma.c | 2 +- 3 files changed, 14 insertions(+), 15 deletions(-)diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 0dcebc24c312..2b6a1643573c 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c
quoted hunk ↗ jump to hunk
@@ -600,11 +599,6 @@ static int fsl_asrc_dai_hw_params(struct snd_pcm_substream *substream, pair->config = &config; - if (asrc_priv->asrc_width == 16) - format = SNDRV_PCM_FORMAT_S16_LE; - else - format = SNDRV_PCM_FORMAT_S24_LE;
It feels better to me that we have format settings in hw_params(). Why not let fsl_easrc align with this? Any reason that I'm missing?