Thread (27 messages) 27 messages, 4 authors, 2020-02-26

Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace

From: Christophe Leroy <hidden>
Date: 2020-02-26 12:03:58
Also in: lkml


Le 24/02/2020 à 11:54, Michael Ellerman a écrit :
Christophe Leroy [off-list ref] writes:
quoted
Le 24/02/2020 à 03:15, Michael Neuling a écrit :
quoted
Christophe,
quoted
Le 28/06/2019 à 17:47, Christophe Leroy a écrit :
quoted
The purpose of this series is to reduce the amount of #ifdefs
in ptrace.c
Any feedback on this series which aims at fixing the issue you opened at
https://github.com/linuxppc/issues/issues/128 ?
Yeah, sorry my bad. You did all the hard work and I ignored it.

I like the approach and is a long the lines I was thinking. Putting it in a
ptrace subdir, splitting out adv_debug_regs, TM, SPE, Alitivec, VSX.
ppc_gethwdinfo() looks a lot nicer now too (that was some of the worst of it).

I've not gone through it with a fine tooth comb though. There is (rightly) a lot
of code moved around which could have introduced some issues.

It applies on v5.2 but are you planning on updating it to a newer base?
As you noticed there is a lot of code moved around, and rebasing
produces a lot of conflicts. So I didn't want to spend hours to rebase
and rebase without being sure it was the right approach.

Now that I got a positive feedback I'll consider rebasing it, hopping
that Michael will pick it up.
I would love to.
Great.

Just sent v3 out.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help