Re: [PATCH v3 08/27] ocxl: Emit a log message showing how much LPC memory was detected
From: Alastair D'Silva <hidden>
Date: 2020-02-24 06:10:20
Also in:
linux-mm, lkml, nvdimm
From: Alastair D'Silva <hidden>
Date: 2020-02-24 06:10:20
Also in:
linux-mm, lkml, nvdimm
On Mon, 2020-02-24 at 17:06 +1100, Andrew Donnellan wrote:
On 21/2/20 2:27 pm, Alastair D'Silva wrote:quoted
From: Alastair D'Silva <redacted> This patch emits a message showing how much LPC memory & special purpose memory was detected on an OCXL device. Signed-off-by: Alastair D'Silva <redacted> --- drivers/misc/ocxl/config.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/misc/ocxl/config.cb/drivers/misc/ocxl/config.c index a62e3d7db2bf..701ae6216abf 100644--- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c@@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(structpci_dev *dev, afu->special_purpose_mem_size = total_mem_size - lpc_mem_size; } + + dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and special purpose memory of %#llx bytes\n", + afu->lpc_mem_size, afu->special_purpose_mem_size); +Printing this at info level for every single AFU seems a bit noisy. Perhaps we can print it only if LPC memory is > 0?
There is an early exit before this if there is no LPC memory. -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819