Re: [PATCH v2 3/4] libnvdimm/region: Introduce NDD_LABELING

From
Jeff Moyer <hidden>
Date
2020-02-13 19:13:00
Also in
lkml, nvdimm
Dan Williams [off-list ref] writes:
quoted hunk
@@ -312,8 +312,9 @@ static ssize_t flags_show(struct device *dev,
 {
 	struct nvdimm *nvdimm = to_nvdimm(dev);
 
-	return sprintf(buf, "%s%s\n",
+	return sprintf(buf, "%s%s%s\n",
 			test_bit(NDD_ALIASING, &nvdimm->flags) ? "alias " : "",
+			test_bit(NDD_LABELING, &nvdimm->flags) ? "label" : "",
                                                                       ^

Missing a space.

The rest looks sane.

Reviewed-by: Jeff Moyer <redacted>
Thread (1 message) 1 message, 1 author, 2020-02-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help