Re: [PATCH] evh_bytechan: fix out of bounds accesses

From
Timur Tabi <timur@kernel.org>
Date
2020-01-15 13:31:22
Reply to
Stephen Rothwell, 2020-01-14
On 1/14/20 12:31 AM, Stephen Rothwell wrote:
quoted hunk ↗ jump to hunk
+/**
+ * ev_byte_channel_send - send characters to a byte stream
+ * @handle: byte stream handle
+ * @count: (input) num of chars to send, (output) num chars sent
+ * @bp: pointer to chars to send
+ *
+ * Returns 0 for success, or an error code.
+ */
+static unsigned int ev_byte_channel_send(unsigned int handle,
+	unsigned int *count, const char *bp)
Well, now you've moved this into the .c file and it is no longer available to other callers.  Anything wrong with keeping it in the .h file?
Thread (28 messages) 28 messages, 7 authors, last reply 2020-03-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help