Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

From
Arnd Bergmann <arnd@arndb.de>
Date
2020-01-08 20:54:18
Also in
dri-devel, linux-alpha, linux-arch, nouveau
Reply to
Krzysztof Kozlowski, 2020-01-08
On Wed, Jan 8, 2020 at 9:05 PM Krzysztof Kozlowski [off-list ref] wrote:
The ioreadX() and ioreadX_rep() helpers have inconsistent interface.  On
some architectures void *__iomem address argument is a pointer to const,
on some not.

Implementations of ioreadX() do not modify the memory under the address
so they can be converted to a "const" version for const-safety and
consistency among architectures.

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks for getting this done!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Changes since v1:
1. Constify also ioreadX_rep() and mmio_insX(),
2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability,
The alpha and parisc versions should be independent, I was thinking
you leave them as separate patches, but this work for me too.

I have no real opinion on the other 8 patches, I would have left
them out completely, but they don't hurt either.

         Arnd
Thread (18 messages) 18 messages, 7 authors, last reply 2020-01-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help