Thread (20 messages) 20 messages, 3 authors, 2020-01-24

Re: [PATCH v2 1/6] fs/readdir: Fix filldir() and filldir64() use of user_access_begin()

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2020-01-22 18:24:52
Also in: linux-mm

[ Sorry about HTML crud, on mobile right now ]

On Wed, Jan 22, 2020, 09:52 Christophe Leroy [off-list ref]
wrote:
-       struct linux_dirent __user * dirent;
+       struct linux_dirent __user * dirent, *dirent0;

Patch looks better, but those names are horrid.

Please just use "prev" for the previous dirent, and leave the current one
as "dirent".

I think that's going to be a lot more legible. But no numbering.

      Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help