Thread (20 messages) 20 messages, 9 authors, 2020-02-08

Re: [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2020-01-31 10:40:15
Also in: linux-devicetree, lkml

Ulf Hansson [off-list ref] writes:
On Sun, 26 Jan 2020 at 12:53, Michael Ellerman [off-list ref] wrote:
quoted
There's an OF helper called of_dma_is_coherent(), which checks if a
device has a "dma-coherent" property to see if the device is coherent
for DMA.

But on some platforms devices are coherent by default, and on some
platforms it's not possible to update existing device trees to add the
"dma-coherent" property.

So add a Kconfig symbol to allow arch code to tell
of_dma_is_coherent() that devices are coherent by default, regardless
of the presence of the property.

Select that symbol on powerpc when NOT_COHERENT_CACHE is not set, ie.
when the system has a coherent cache.

Fixes: 92ea637edea3 ("of: introduce of_dma_is_coherent() helper")
Cc: stable@vger.kernel.org # v3.16+
Reported-by: Christian Zigotzky <redacted>
Tested-by: Christian Zigotzky <redacted>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks Michael for helping out fixing and this! The patch looks good to me.

Reviewed-by: Ulf Hansson <redacted>
Thanks for the review.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help