Re: [PATCH v2] Fix display of Maximum Memory
From: Tyrel Datwyler <tyreld@linux.ibm.com>
Date: 2020-01-16 00:08:18
Also in:
lkml
On 1/15/20 6:53 AM, Michael Bringmann wrote:
Correct overflow problem in calculation+display of Maximum Memory value to syscfg where 32bits is insufficient.
Probably needs the following Fixes tag:
Fixes: 772b039fd9a7 ("powerpc/pseries: Export maximum memory value")
otherwise,
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Bringmann <redacted> --- arch/powerpc/platforms/pseries/lparcfg.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platforms/pseries/lparcfg.c index e33e8bc..f00411c 100644 --- a/arch/powerpc/platforms/pseries/lparcfg.c +++ b/arch/powerpc/platforms/pseries/lparcfg.c@@ -433,12 +433,12 @@ static void parse_em_data(struct seq_file *m) static void maxmem_data(struct seq_file *m) { - unsigned long maxmem = 0; + u64 maxmem = 0; - maxmem += drmem_info->n_lmbs * drmem_info->lmb_size; - maxmem += hugetlb_total_pages() * PAGE_SIZE; + maxmem += (u64)drmem_info->n_lmbs * drmem_info->lmb_size; + maxmem += (u64)hugetlb_total_pages() * PAGE_SIZE; - seq_printf(m, "MaxMem=%ld\n", maxmem); + seq_printf(m, "MaxMem=%llu\n", maxmem); } static int pseries_lparcfg_data(struct seq_file *m, void *v)