On Jan 10, 2020, at 10:56 AM, Thomas Gleixner [off-list ref] wrote:

Andy Lutomirski [off-list ref] writes:

quoted

quoted

On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
[off-list ref] wrote:

In order to simplify next step which moves fallback call at arch
level, ensure all arches have a 32bit fallback instead of handling
the lack of 32bit fallback in the common code based
on VDSO_HAS_32BIT_FALLBACK

I don't like this.  You've implemented what appear to be nonsensical
fallbacks (the 32-bit fallback for a 64-bit vDSO build?  There's no
such thing).

How exactly does this simplify patch 2?

There is a patchset from Vincenzo which fell through the cracks which
addresses the VDS_HAS_32BIT_FALLBACK issue properly. I'm about to pick
it up. See:

https://lore.kernel.org/lkml/20190830135902.20861-1-vincenzo.frascino@arm.com/ (local)

Thanks.  I had been wondering why the conditionals were still there, since I remember seeing these patches.

Thanks,

       tglx