Re: [PATCH v3] platforms/powernv: Avoid re-registration of imc debugfs directory
From: Michael Ellerman <hidden>
Date: 2019-12-09 05:48:29
From: Michael Ellerman <hidden>
Date: 2019-12-09 05:48:29
On Wed, 2019-11-27 at 07:20:35 UTC, Anju T Sudhakar wrote:
export_imc_mode_and_cmd() function which creates the debugfs interface for imc-mode and imc-command, is invoked when each nest pmu units is registered. When the first nest pmu unit is registered, export_imc_mode_and_cmd() creates 'imc' directory under `/debug/powerpc/`. In the subsequent invocations debugfs_create_dir() function returns, since the directory already exists. The recent commit <c33d442328f55> (debugfs: make error message a bit more verbose), throws a warning if we try to invoke `debugfs_create_dir()` with an already existing directory name. Address this warning by making the debugfs directory registration in the opal_imc_counters_probe() function, i.e invoke export_imc_mode_and_cmd() function from the probe function. Signed-off-by: Anju T Sudhakar <redacted>
Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/48e626ac85b43cc589dd1b3b8004f7f85f03544d cheers