Hi Sukadev,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.5-rc3 next-20191220]
[cannot apply to kvm-ppc/kvm-ppc-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sukadev-Bhattiprolu/powerpc-pseries-svm-Use-FW_FEATURE-to-detect-SVM/20191226-045626
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-rhel-kconfig (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/process.c: In function 'save_sprs':

quoted

arch/powerpc/kernel/process.c:1065:8: error: implicit declaration of function 'is_secure_guest'; did you mean 'issecure_mask'? [-Werror=implicit-function-declaration]

      if (!is_secure_guest()) {
           ^~~~~~~~~~~~~~~
           issecure_mask
   cc1: some warnings being treated as errors
--
   arch/powerpc/kvm/book3s_hv.c: In function 'kvmhv_p9_guest_entry':

quoted

arch/powerpc/kvm/book3s_hv.c:3554:7: error: implicit declaration of function 'is_secure_guest'; did you mean 'is_software_event'? [-Werror=implicit-function-declaration]

     if (!is_secure_guest()) {
          ^~~~~~~~~~~~~~~
          is_software_event
   cc1: some warnings being treated as errors
--
   arch/powerpc/perf/core-book3s.c: In function 'perf_event_print_debug':

quoted

arch/powerpc/perf/core-book3s.c:814:6: error: implicit declaration of function 'is_secure_guest' [-Werror=implicit-function-declaration]

     if (is_secure_guest()) {
         ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1065 arch/powerpc/kernel/process.c

  1053	
  1054	static inline void save_sprs(struct thread_struct *t)
  1055	{
  1056	#ifdef CONFIG_ALTIVEC
  1057		if (cpu_has_feature(CPU_FTR_ALTIVEC))
  1058			t->vrsave = mfspr(SPRN_VRSAVE);
  1059	#endif
  1060	#ifdef CONFIG_PPC_BOOK3S_64
  1061		if (cpu_has_feature(CPU_FTR_DSCR))
  1062			t->dscr = mfspr(SPRN_DSCR);
  1063	
  1064		if (cpu_has_feature(CPU_FTR_ARCH_207S)) {

1065			if (!is_secure_guest()) {

  1066				t->bescr = mfspr(SPRN_BESCR);
  1067				t->ebbhr = mfspr(SPRN_EBBHR);
  1068				t->ebbrr = mfspr(SPRN_EBBRR);
  1069			}
  1070	
  1071			t->fscr = mfspr(SPRN_FSCR);
  1072	
  1073			/*
  1074			 * Note that the TAR is not available for use in the kernel.
  1075			 * (To provide this, the TAR should be backed up/restored on
  1076			 * exception entry/exit instead, and be in pt_regs.  FIXME,
  1077			 * this should be in pt_regs anyway (for debug).)
  1078			 */
  1079			t->tar = mfspr(SPRN_TAR);
  1080		}
  1081	#endif
  1082	
  1083		thread_pkey_regs_save(t);
  1084	}
  1085	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation