Re: [PATCH] powerpc/shared: include correct header for static key
From: Srikar Dronamraju <hidden>
Date: 2019-12-24 16:23:01
Also in:
lkml
* Jason A. Donenfeld [off-list ref] [2019-12-23 14:31:47]:
Recently, the spinlock implementation grew a static key optimization, but the jump_label.h header include was left out, leading to build errors: linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ???static_branch_unlikely??? [-Werror=implicit-function-declaration] 44 | if (!static_branch_unlikely(&shared_processor)) This commit adds the missing header.
Right, This was in v4 version of the patchset (http://lkml.kernel.org/r/20191212085344.17357-1-srikar@linux.vnet.ibm.com) but we missed it in the final v5 version. Thanks for noticing and fixing it. Reviewed-by: Srikar Dronamraju <redacted>
quoted hunk
Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor") Cc: Srikar Dronamraju <redacted> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> --- arch/powerpc/include/asm/spinlock.h | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h index 1b55fc08f853..860228e917dc 100644 --- a/arch/powerpc/include/asm/spinlock.h +++ b/arch/powerpc/include/asm/spinlock.h@@ -15,6 +15,7 @@ * * (the type definitions are in asm/spinlock_types.h) */ +#include <linux/jump_label.h> #include <linux/irqflags.h> #ifdef CONFIG_PPC64 #include <asm/paca.h>-- 2.24.1
-- Thanks and Regards Srikar Dronamraju