Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED

On Thu, Dec 5, 2019 at 11:18 AM Michael Walle [off-list ref] wrote:

Hi Daniel,

Am 2019-12-05 09:43, schrieb Daniel Baluta:

quoted

On Fri, Nov 29, 2019 at 12:40 AM Michael Walle [off-list ref]
wrote:

quoted

The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use
IRQF_SHARED to be able to use these SAIs simultaneously.

Hi Michael,

Thanks for the patch. We have a similar change inside our internal tree
(it is on my long TODO list to upstream :D).

We add the shared flag conditionally on a dts property.

Do you think it is a good idea to always add shared flag? I'm thinking
on SAI IP integrations where the interrupt is edge triggered.

Mhh, I don't really get the point to make the flag conditionally. If
there is only one user, the flag won't hurt, correct?

If there are two users, we need the flag anyway.

quoted

AFAIK edge triggered interrupts do not get along very well
with sharing an interrupt line.

So in that case you shouldn't use shared edge triggered interrupts in
the
SoC in the first place, I guess.

I think you make a good point. I was thinking that it would hurt the single
user case. But it is fine.

Thanks for the patch.

Acked-by: Daniel Baluta <daniel.baluta@nxp.com>