Thread (14 messages) flat view 14 messages, 8 authors, 2019-12-15

Re: [PATCH] libbpf: fix readelf output parsing on powerpc with recent binutils

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2019-12-02 09:37:57
Also in: bpf, lkml, netdev

On Mon, Dec 02, 2019 at 04:53:26PM +1100, Michael Ellerman wrote:
Aurelien Jarno [off-list ref] writes:
quoted
On powerpc with recent versions of binutils, readelf outputs an extra
field when dumping the symbols of an object file. For example:

    35: 0000000000000838    96 FUNC    LOCAL  DEFAULT [<localentry>: 8]     1 btf_is_struct

The extra "[<localentry>: 8]" prevents the GLOBAL_SYM_COUNT variable to
be computed correctly and causes the checkabi target to fail.

Fix that by looking for the symbol name in the last field instead of the
8th one. This way it should also cope with future extra fields.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 tools/lib/bpf/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for fixing that, it's been on my very long list of test failures
for a while.

Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good & also continues to work on x86. Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help