Re: [PATCH v4 0/5] Early node associativity
From: Srikar Dronamraju <hidden>
Date: 2019-11-15 13:39:13
Hi Michael,
Nathan Lynch [off-list ref] writes:quoted
Srikar Dronamraju [off-list ref] writes:quoted
Abdul reported a warning on a shared lpar. "WARNING: workqueue cpumask: online intersect > possible intersect". This is because per node workqueue possible mask is set very early in the boot process even before the system was querying the home node associativity. However per node workqueue online cpumask gets updated dynamically. Hence there is a chance when per node workqueue online cpumask is a superset of per node workqueue possible mask.Sorry for the delay in following up on these. The series looks good to me, and I've given it a little testing with LPM and DLPAR. I've also verified that the cpu assignments occur early as intended on an LPAR where that workqueue warning had been triggered.If this is applied I think we can remove about 500 loc from numa.c. Once splpar cpu-node assignments are done in the same sequence as with dedicated processor mode, numa_update_cpu_topology() and related code becomes unneeded.
Since its 2 months since version 5 was posted and more than a month since Nathan added his reviewed-by, can you please let us know if there is any reason why this patchset has not been applied yet. Or do let me know if have any further comments. -- Thanks and Regards Srikar Dronamraju