Re: [PATCH 7/9] PCI: rpaphp: annotate and correctly byte swap DRC properties
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-11-07 11:44:19
Tyrel Datwyler [off-list ref] writes:
The device tree is in big endian format and any properties directly retrieved using OF helpers that don't explicitly byte swap should be annotated. In particular there are several places where we grab the opaque property value for the old ibm,drc-* properties and the ibm,my-drc-index property. Fix this for better static checking by annotating values we know to explicitly big endian, and byte swap where appropriate. Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com> --- drivers/pci/hotplug/rpaphp_core.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
This is allegedly still popping some sparse warnings: +drivers/pci/hotplug/rpaphp_core.c:XX:28: warning: incorrect type in assignment (different base types) expected restricted __be32 const [usertype] * got int const *[assigned] names +drivers/pci/hotplug/rpaphp_core.c:XX:28: warning: incorrect type in assignment (different base types) expected restricted __be32 const [usertype] * got int const *[assigned] types +drivers/pci/hotplug/rpaphp_core.c:XX:30: warning: incorrect type in assignment (different base types) expected restricted __be32 const [usertype] * got int const *[assigned] indexes +drivers/pci/hotplug/rpaphp_core.c:XX:36: warning: incorrect type in assignment (different base types) expected restricted __be32 const [usertype] * got int const *[assigned] domains I say allegedly because that output's from a script that tries to diff sparse warnings before and after the build and it's not always 100% reliable. cheers